Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: presubmit_support.py

Issue 1382993004: presubmit: unblacklist third_party/WebKit (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Add comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Enables directory-specific presubmit checks to run at upload and/or commit. 6 """Enables directory-specific presubmit checks to run at upload and/or commit.
7 """ 7 """
8 8
9 __version__ = '1.8.0' 9 __version__ = '1.8.0'
10 10
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$", 238 r".+\.js$", r".+\.py$", r".+\.sh$", r".+\.rb$", r".+\.pl$", r".+\.pm$",
239 # Other 239 # Other
240 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$" 240 r".+\.java$", r".+\.mk$", r".+\.am$", r".+\.css$"
241 ) 241 )
242 242
243 # Path regexp that should be excluded from being considered containing source 243 # Path regexp that should be excluded from being considered containing source
244 # files. Don't modify this list from a presubmit script! 244 # files. Don't modify this list from a presubmit script!
245 DEFAULT_BLACK_LIST = ( 245 DEFAULT_BLACK_LIST = (
246 r"testing_support[\\\/]google_appengine[\\\/].*", 246 r"testing_support[\\\/]google_appengine[\\\/].*",
247 r".*\bexperimental[\\\/].*", 247 r".*\bexperimental[\\\/].*",
248 r".*\bthird_party[\\\/].*", 248 # Exclude third_party/.* but NOT third_party/WebKit (crbug.com/539768).
249 r".*\bthird_party[\\\/](?!WebKit[\\\/]).*",
249 # Output directories (just in case) 250 # Output directories (just in case)
250 r".*\bDebug[\\\/].*", 251 r".*\bDebug[\\\/].*",
251 r".*\bRelease[\\\/].*", 252 r".*\bRelease[\\\/].*",
252 r".*\bxcodebuild[\\\/].*", 253 r".*\bxcodebuild[\\\/].*",
253 r".*\bout[\\\/].*", 254 r".*\bout[\\\/].*",
254 # All caps files like README and LICENCE. 255 # All caps files like README and LICENCE.
255 r".*\b[A-Z0-9_]{2,}$", 256 r".*\b[A-Z0-9_]{2,}$",
256 # SCM (can happen in dual SCM configuration). (Slightly over aggressive) 257 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
257 r"(|.*[\\\/])\.git[\\\/].*", 258 r"(|.*[\\\/])\.git[\\\/].*",
258 r"(|.*[\\\/])\.svn[\\\/].*", 259 r"(|.*[\\\/])\.svn[\\\/].*",
(...skipping 1492 matching lines...) Expand 10 before | Expand all | Expand 10 after
1751 return 2 1752 return 2
1752 1753
1753 1754
1754 if __name__ == '__main__': 1755 if __name__ == '__main__':
1755 fix_encoding.fix_encoding() 1756 fix_encoding.fix_encoding()
1756 try: 1757 try:
1757 sys.exit(main()) 1758 sys.exit(main())
1758 except KeyboardInterrupt: 1759 except KeyboardInterrupt:
1759 sys.stderr.write('interrupted\n') 1760 sys.stderr.write('interrupted\n')
1760 sys.exit(1) 1761 sys.exit(1)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698