Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382753002: Fix drawVertices when there is a paint alpha (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix drawVertices when there is a paint alpha

Patch Set 1 #

Patch Set 2 : update #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -42 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +33 lines, -25 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 3 chunks +25 lines, -12 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 2 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bsalomon
5 years, 2 months ago (2015-10-01 15:07:09 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1382753002/diff/20001/src/gpu/SkGrPriv.h File src/gpu/SkGrPriv.h (right): https://codereview.chromium.org/1382753002/diff/20001/src/gpu/SkGrPriv.h#newcode91 src/gpu/SkGrPriv.h:91: inline rm \n ?
5 years, 2 months ago (2015-10-01 15:23:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382753002/40001
5 years, 2 months ago (2015-10-01 15:27:55 UTC) #6
bsalomon
https://codereview.chromium.org/1382753002/diff/20001/src/gpu/SkGrPriv.h File src/gpu/SkGrPriv.h (right): https://codereview.chromium.org/1382753002/diff/20001/src/gpu/SkGrPriv.h#newcode91 src/gpu/SkGrPriv.h:91: inline On 2015/10/01 15:23:23, robertphillips wrote: > rm \n ...
5 years, 2 months ago (2015-10-01 15:34:40 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
5 years, 2 months ago (2015-10-01 15:35:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382753002/40001
5 years, 2 months ago (2015-10-01 16:29:05 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 16:30:04 UTC) #13 
Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

Powered by Google App Engine
This is Rietveld 408576698