Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

Issue 1382743002: bluetooth: Add characteristicvaluechanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-notifications-1
Patch Set: Address palmer's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl
index b6d8d57ea7241a3c634ddd698968639d6a78b9e9..ad1874a164e0e72c9d34d814c555e4762cc315af 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl
@@ -10,17 +10,21 @@
GarbageCollected,
ActiveDOMObject,
RuntimeEnabled=WebBluetooth,
-] interface BluetoothGATTCharacteristic {//: CharacteristicEventHandlers {
+] interface BluetoothGATTCharacteristic : EventTarget {//: CharacteristicEventHandlers {
// TODO(ortuno): Add test to make sure service matches the service
// used to call getCharacteristic.
// readonly attribute BluetoothGATTService service;
readonly attribute UUID uuid;
// readonly attribute CharacteristicProperties properties;
- // readonly attribute ArrayBuffer? value;
+ readonly attribute ArrayBuffer? value;
// Promise<BluetoothGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);
// Promise<sequence<BluetoothGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);
[CallWith=ScriptState] Promise<ArrayBuffer> readValue();
[CallWith=ScriptState] Promise<void> writeValue(BufferSource value);
[CallWith=ScriptState] Promise<void> startNotifications();
[CallWith=ScriptState] Promise<void> stopNotifications();
+
+ // TODO(ortuno): Move this to CharacteristicEventHandlers.
tkent 2015/10/19 23:00:59 indentation error
ortuno 2015/10/20 01:12:12 Done.
+ // http://crbug.com/537459
+ attribute EventHandler oncharacteristicvaluechanged;
};

Powered by Google App Engine
This is Rietveld 408576698