third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h - Issue 1382743002: bluetooth: Add characteristicvaluechanged event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h

Issue 1382743002: bluetooth: Add characteristicvaluechanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-notifications-1

Patch Set: Address palmer's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl ('K') | « third_party/WebKit/Source/modules/bluetooth/DEPS ('k') | third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothGATTCharacteristic.h » ('j') | third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothGATTCharacteristic.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h

diff --git a/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h b/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h

index 445c074a22a4dfbc95f93e6b73bf53972379fb6f..1cdd4cbd383b729c26280ea462078295c19818d7 100644

--- a/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h

+++ b/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h

@@ -86,6 +86,11 @@ public:

virtual void stopNotifications(const WebString& characteristicInstanceID,

WebBluetoothGATTCharacteristic*,

WebBluetoothNotificationsCallbacks*) {}

+ // Called when addEventListener is called on a characteristic.

+ virtual void registerCharacteristicObject(

+ const WebString& characteristicInstanceID,

+ WebBluetoothGATTCharacteristic*) {}

tkent 2015/10/19 23:00:59 |{}| -> |= 0|. We don't need to provide an empty

ortuno 2015/10/20 01:12:12 Done.

virtual void characteristicObjectRemoved(

const WebString& characteristicInstanceID,

WebBluetoothGATTCharacteristic*) {}