Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 138273018: Use synthetic bold/italic terminology consistently (Closed)

Created:
6 years, 11 months ago by eae
Modified:
6 years, 11 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Use synthetic bold/italic terminology consistently We currently use the terms fake bold/italic and synthetic bold/ italic interchangeably. This change replaces all uses with the more descriptive synthetic bold/italic terminology. BUG=335768 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/fonts/skia/FontPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 10 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
6 years, 11 months ago (2014-01-17 23:28:38 UTC) #1
dglazkov
lgtm, wanted to do this myself.
6 years, 11 months ago (2014-01-17 23:34:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/138273018/1
6 years, 11 months ago (2014-01-18 00:54:46 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 01:47:20 UTC) #4
Message was sent while issue was closed.
Change committed as 165354

Powered by Google App Engine
This is Rietveld 408576698