Use synthetic bold/italic terminology consistently

Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp

 /*
  * Copyright (c) 2006, 2007, 2008, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 62 matching lines @@
 }
 
 void FontPlatformData::setSubpixelRendering(bool useSubpixelRendering)
 {
     useSkiaSubpixelRendering = useSubpixelRendering;
 }
 
 FontPlatformData::FontPlatformData(WTF::HashTableDeletedValueType)
     : m_textSize(0)
     , m_emSizeInFontUnits(0)
-    , m_fakeBold(false)
-    , m_fakeItalic(false)
+    , m_syntheticBold(false)
+    , m_syntheticItalic(false)
     , m_orientation(Horizontal)
     , m_isHashTableDeletedValue(true)
 {
 }
 
 FontPlatformData::FontPlatformData()
     : m_textSize(0)
     , m_emSizeInFontUnits(0)
-    , m_fakeBold(false)
-    , m_fakeItalic(false)
+    , m_syntheticBold(false)
+    , m_syntheticItalic(false)
     , m_orientation(Horizontal)
     , m_isHashTableDeletedValue(false)
 {
 }
 
-FontPlatformData::FontPlatformData(float textSize, bool fakeBold, bool fakeItalic)
+FontPlatformData::FontPlatformData(float textSize, bool syntheticBold, bool syntheticItalic)
     : m_textSize(textSize)
     , m_emSizeInFontUnits(0)
-    , m_fakeBold(fakeBold)
-    , m_fakeItalic(fakeItalic)
+    , m_syntheticBold(syntheticBold)
+    , m_syntheticItalic(syntheticItalic)
     , m_orientation(Horizontal)
     , m_isHashTableDeletedValue(false)
 {
 }
 
 FontPlatformData::FontPlatformData(const FontPlatformData& src)
     : m_typeface(src.m_typeface)
     , m_family(src.m_family)
     , m_textSize(src.m_textSize)
     , m_emSizeInFontUnits(src.m_emSizeInFontUnits)
-    , m_fakeBold(src.m_fakeBold)
-    , m_fakeItalic(src.m_fakeItalic)
+    , m_syntheticBold(src.m_syntheticBold)
+    , m_syntheticItalic(src.m_syntheticItalic)
     , m_orientation(src.m_orientation)
     , m_style(src.m_style)
     , m_harfBuzzFace(0)
     , m_isHashTableDeletedValue(false)
 {
 }
 
-FontPlatformData::FontPlatformData(PassRefPtr<SkTypeface> tf, const char* family, float textSize, bool fakeBold, bool fakeItalic, FontOrientation orientation, bool subpixelTextPosition)
+FontPlatformData::FontPlatformData(PassRefPtr<SkTypeface> tf, const char* family, float textSize, bool syntheticBold, bool syntheticItalic, FontOrientation orientation, bool subpixelTextPosition)
     : m_typeface(tf)
     , m_family(family)
     , m_textSize(textSize)
     , m_emSizeInFontUnits(0)
-    , m_fakeBold(fakeBold)
-    , m_fakeItalic(fakeItalic)
+    , m_syntheticBold(syntheticBold)
+    , m_syntheticItalic(syntheticItalic)
     , m_orientation(orientation)
     , m_isHashTableDeletedValue(false)
 {
     querySystemForRenderStyle(subpixelTextPosition);
 }
 
 FontPlatformData::FontPlatformData(const FontPlatformData& src, float textSize)
     : m_typeface(src.m_typeface)
     , m_family(src.m_family)
     , m_textSize(textSize)
     , m_emSizeInFontUnits(src.m_emSizeInFontUnits)
-    , m_fakeBold(src.m_fakeBold)
-    , m_fakeItalic(src.m_fakeItalic)
+    , m_syntheticBold(src.m_syntheticBold)
+    , m_syntheticItalic(src.m_syntheticItalic)
     , m_orientation(src.m_orientation)
     , m_harfBuzzFace(0)
     , m_isHashTableDeletedValue(false)
 {
     querySystemForRenderStyle(FontDescription::subpixelPositioning());
 }
 
 FontPlatformData::~FontPlatformData()
 {
 }
 
 int FontPlatformData::emSizeInFontUnits() const
 {
     if (m_emSizeInFontUnits)
         return m_emSizeInFontUnits;
 
     m_emSizeInFontUnits = m_typeface->getUnitsPerEm();
     return m_emSizeInFontUnits;
 }
 
 FontPlatformData& FontPlatformData::operator=(const FontPlatformData& src)
 {
     m_typeface = src.m_typeface;
     m_family = src.m_family;
     m_textSize = src.m_textSize;
-    m_fakeBold = src.m_fakeBold;
-    m_fakeItalic = src.m_fakeItalic;
+    m_syntheticBold = src.m_syntheticBold;
+    m_syntheticItalic = src.m_syntheticItalic;
     m_harfBuzzFace = 0;
     m_orientation = src.m_orientation;
     m_style = src.m_style;
     m_emSizeInFontUnits = src.m_emSizeInFontUnits;
 
     return *this;
 }
 
 #ifndef NDEBUG
 String FontPlatformData::description() const
@@ skipping 13 matching lines @@
 
     // TestRunner specifically toggles the subpixel positioning flag.
     if (RuntimeEnabledFeatures::subpixelFontScalingEnabled() && !isRunningLayoutTest())
         paint->setSubpixelText(true);
     else
         paint->setSubpixelText(m_style.useSubpixelPositioning);
 
     const float ts = m_textSize >= 0 ? m_textSize : 12;
     paint->setTextSize(SkFloatToScalar(ts));
     paint->setTypeface(m_typeface.get());
-    paint->setFakeBoldText(m_fakeBold);
-    paint->setTextSkewX(m_fakeItalic ? -SK_Scalar1 / 4 : 0);
+    paint->setFakeBoldText(m_syntheticBold);
+    paint->setTextSkewX(m_syntheticItalic ? -SK_Scalar1 / 4 : 0);
 }
 
 SkFontID FontPlatformData::uniqueID() const
 {
     return m_typeface->uniqueID();
 }
 
 String FontPlatformData::fontFamilyName() const
 {
     // FIXME(crbug.com/326582): come up with a proper way of handling SVG.
@@ skipping 11 matching lines @@
     // If either of the typeface pointers are null then we test for pointer
     // equality. Otherwise, we call SkTypeface::Equal on the valid pointers.
     bool typefacesEqual;
     if (!m_typeface || !a.m_typeface)
         typefacesEqual = m_typeface == a.m_typeface;
     else
         typefacesEqual = SkTypeface::Equal(m_typeface.get(), a.m_typeface.get());
 
     return typefacesEqual
         && m_textSize == a.m_textSize
-        && m_fakeBold == a.m_fakeBold
-        && m_fakeItalic == a.m_fakeItalic
+        && m_syntheticBold == a.m_syntheticBold
+        && m_syntheticItalic == a.m_syntheticItalic
         && m_orientation == a.m_orientation
         && m_style == a.m_style
         && m_isHashTableDeletedValue == a.m_isHashTableDeletedValue;
 }
 
 bool FontPlatformData::isFixedPitch() const
 {
     notImplemented();
     return false;
 }
@@ skipping 46 matching lines @@
     if (m_style.useSubpixelRendering == FontRenderStyle::NoPreference)
         m_style.useSubpixelRendering = useSkiaSubpixelRendering;
 
     // TestRunner specifically toggles the subpixel positioning flag.
     if (m_style.useSubpixelPositioning == FontRenderStyle::NoPreference
         || isRunningLayoutTest())
         m_style.useSubpixelPositioning = useSkiaSubpixelPositioning;
 }
 
 } // namespace WebCore