Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1382383002: Revert of Provide the DeviceManager service to the renderer directly, no app. (Closed)

Created:
5 years, 2 months ago by Finnur
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@interface_permission
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Provide the DeviceManager service to the renderer directly, no app. (patchset #5 id:80001 of https://codereview.chromium.org/1371793004/ ) Reason for revert: It is causing a number of layout tests to fail with error: 01:16:18.824 21620 [4:4:1005/011618:1968830910:ERROR:web_usb_client_impl.cc(72)] Device manager connection failed. See for example: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/45170/steps/webkit_tests/logs/stdio Original issue's description: > Provide the DeviceManager service to the renderer directly, no app. > > The Mojo app model forces us to create a new thread on which to run the > device manager. Inside Chrome this then means that we have to post tasks > to the UI thread in order to use the UsbService instance it is > implemented with. This patch removes the devices app from Chrome, > instead registering a factory function for DeviceManagers directly with > the RenderFrameHost. DeviceManagerImpl can then live on the UI thread > which greatly simplfies its implementation. Otherwise we would have to > implement similar thread hopping in DeviceImpl and that would be a lot > of unnecessary code. > > Committed: https://crrev.com/869af1c5170c48b8987b7ce4e2c70c9b37f9beb7 > Cr-Commit-Position: refs/heads/master@{#352222} TBR=rockot@chromium.org,thestig@chromium.org,jam@chromium.org,reillyg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/66407392ea95965f34b9c69993d0da3a674ca60b Cr-Commit-Position: refs/heads/master@{#352312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -103 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/usb/web_usb_client_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/usb/web_usb_client_impl.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M device/devices_app/devices_app.h View 3 chunks +7 lines, -1 line 0 comments Download
M device/devices_app/devices_app.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M device/devices_app/public/cpp/devices_app_factory.h View 2 chunks +11 lines, -1 line 0 comments Download
M device/devices_app/public/cpp/devices_app_factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.h View 7 chunks +16 lines, -16 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 6 chunks +111 lines, -30 lines 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Finnur
Created Revert of Provide the DeviceManager service to the renderer directly, no app.
5 years, 2 months ago (2015-10-05 10:18:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382383002/1
5 years, 2 months ago (2015-10-05 10:18:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 10:19:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66407392ea95965f34b9c69993d0da3a674ca60b Cr-Commit-Position: refs/heads/master@{#352312}
5 years, 2 months ago (2015-10-05 10:20:09 UTC) #4
Finnur
5 years, 2 months ago (2015-10-05 11:08:59 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1387823002/ by finnur@chromium.org.

The reason for reverting is: Revert the revert, since it doesn't apply cleanly
(despite passing the CQ)  (sigh).

Powered by Google App Engine
This is Rietveld 408576698