Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: device/devices_app/public/cpp/devices_app_factory.h

Issue 1382383002: Revert of Provide the DeviceManager service to the renderer directly, no app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interface_permission
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/devices_app/devices_app.cc ('k') | device/devices_app/public/cpp/devices_app_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/devices_app/public/cpp/devices_app_factory.h
diff --git a/device/devices_app/public/cpp/devices_app_factory.h b/device/devices_app/public/cpp/devices_app_factory.h
index ba031850f42484ce55c8f0678f615278b2f18ddd..564274124522bb87367d83043167ebddef212b69 100644
--- a/device/devices_app/public/cpp/devices_app_factory.h
+++ b/device/devices_app/public/cpp/devices_app_factory.h
@@ -7,6 +7,10 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+
+namespace base {
+class SequencedTaskRunner;
+}
namespace mojo {
class ApplicationDelegate;
@@ -20,7 +24,13 @@
// Creates a DevicesApp delegate which can be used to launch a new instance
// of the devices app on a mojo application runner. The caller owns the
// delegate.
- static scoped_ptr<mojo::ApplicationDelegate> CreateApp();
+ //
+ // |service_task_runner| is the thread TaskRunner on which the UsbService
+ // lives. This argument should be removed once UsbService is owned by the
+ // USB device manager and no longer part of the public device API. If null,
+ // the app will construct its own DeviceClient and UsbService.
+ static scoped_ptr<mojo::ApplicationDelegate> CreateApp(
+ scoped_refptr<base::SequencedTaskRunner> service_task_runner);
};
} // namespace device
« no previous file with comments | « device/devices_app/devices_app.cc ('k') | device/devices_app/public/cpp/devices_app_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698