dart2js: set effective target for patched constructors

dart2js: set effective target for patched constructors

Closes #24461

BUG=
R=johnniwinther@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/e067a52e44e168399602b38be97ccbc338fe9724

[Harry Terkelsen, 2015-10-03 00:48:19]

het@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-10-05 17:09:06]

sra@google.com changed reviewers:
+ johnniwinther@google.com

[sra1, 2015-10-05 17:09:06]

LGTM.

+johnniwinther@google.com would know if there is a cleaner way.

[Johnni Winther, 2015-10-06 10:38:14]

LGTM with comments.

The dart2js/patch_test/bug (testEffectiveTarget) should be fixed by this, right?

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2207: if (isPatched) {
Why is this needed?

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:474: Statement redirectionNode =
functionNode.body;
Why is this needed?

[Harry Terkelsen, 2015-10-12 18:17:44]

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2207: if (isPatched) {
On 2015/10/06 10:38:14, Johnni Winther wrote:
> Why is this needed?

There are targets that are patched but are not redirecting factories, so we need
to check that internalEffectiveTarget is set (by the method which resolves
chains of redirecting factories)

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/1382313002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/resolution.dart:474: Statement redirectionNode =
functionNode.body;
On 2015/10/06 10:38:14, Johnni Winther wrote:
> Why is this needed?

Good catch, it's not needed. It was from an earlier revision of this change

[Harry Terkelsen, 2015-10-12 18:19:07]

Committed patchset #2 (id:20001) manually as
e067a52e44e168399602b38be97ccbc338fe9724 (presubmit successful).