pkg/compiler/lib/src/elements/modelx.dart - Issue 1382313002: dart2js: set effective target for patched constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1382313002: dart2js: set effective target for patched constructors (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/elements/modelx.dart

diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart

index 22a9dcba02de0922d275e3248661c74c54eb2cff..0109684f7ba6c14cfd741405f579e2bf3cf3ff8c 100644

--- a/pkg/compiler/lib/src/elements/modelx.dart

+++ b/pkg/compiler/lib/src/elements/modelx.dart

@@ -2227,7 +2227,11 @@ abstract class ConstructorElementX extends FunctionElementX

return immediateRedirectionTarget;

}

assert(!isRedirectingFactory || internalEffectiveTarget != null);

- return isRedirectingFactory ? internalEffectiveTarget : this;

+ if (isRedirectingFactory) return internalEffectiveTarget;

+ if (isPatched) {

+ return internalEffectiveTarget ?? this;

+ }

+ return this;

}

InterfaceType computeEffectiveTargetType(InterfaceType newType) {