scripts/slave/recipe_modules/bot_update/test_api.py - Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bot_update/test_api.py

Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Fixes + coverage. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json ('K') | « scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/bot_update/test_api.py

diff --git a/scripts/slave/recipe_modules/bot_update/test_api.py b/scripts/slave/recipe_modules/bot_update/test_api.py

index 013bfdb3a84f50556ff925a629011c51915f73b7..282446cd1c8c15c9fcf48334d4c80165e8af486f 100644

--- a/scripts/slave/recipe_modules/bot_update/test_api.py

+++ b/scripts/slave/recipe_modules/bot_update/test_api.py

@@ -72,6 +72,9 @@ class BotUpdateTestApi(recipe_test_api.RecipeTestApi):

if fail_patch:

output['log_lines'] = [('patch error', 'Patch failed to apply'),]

output['patch_failure'] = True

+ output['return_code'] = 1

Sergiy Byelozyorov 2015/10/02 12:44:35 if fail_patch == 'apply': output['return_code']

tandrii(chromium) 2015/10/02 12:50:36 If it's 0 OR if apply_issue isn't run at all, it's

+ if fail_patch == 'download':

+ output['return_code'] = 3

return self.m.json.output(output)

@staticmethod