scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json - Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Fixes + coverage. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json ('K') | « scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json ('k') | scripts/slave/recipe_modules/bot_update/test_api.py » ('j') | scripts/slave/recipe_modules/bot_update/test_api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

diff --git a/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json b/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

similarity index 93%

copy from scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json

copy to scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

index 69f65f215be8ee9d18128ea44f41fd6ea0b15ed3..af87b9c0a0917749a5c76198326a329c6136ecb0 100644

--- a/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json

+++ b/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

@@ -26,6 +26,7 @@

"cwd": "[SLAVE_BUILD]",

"name": "bot_update",

"~followup_annotations": [

+ "step returned non-zero exit code: 3",

"@@@STEP_TEXT@Some step text@@@",

"@@@STEP_LOG_LINE@json.output@{@@@",

"@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",

@@ -38,13 +39,14 @@

"@@@STEP_LOG_LINE@json.output@ \"patch_failure\": true, @@@",

"@@@STEP_LOG_LINE@json.output@ \"patch_root\": \"src\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"properties\": {}, @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"return_code\": 3, @@@",

tandrii(chromium) 2015/10/02 12:50:36 This is THE important change.

"@@@STEP_LOG_LINE@json.output@ \"root\": \"src\", @@@",

"@@@STEP_LOG_LINE@json.output@ \"step_text\": \"Some step text\"@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

"@@@STEP_LOG_END@json.output@@@",

"@@@STEP_LOG_LINE@patch error@Patch failed to apply@@@",

"@@@STEP_LOG_END@patch error@@@",

- "@@@SET_BUILD_PROPERTY@failure_type@\"PATCH_FAILURE\"@@@"

+ "@@@STEP_EXCEPTION@@@"

Sergiy Byelozyorov 2015/10/02 12:44:35 I don't see INFRA_FAILURE anywhere in this expecta

tandrii(chromium) 2015/10/02 12:50:36 bad.. let's see...

]

{