Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 138213005: Revert "Remove children of title node before updating" (Closed)

Created:
6 years, 11 months ago by davve
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Remove children of title node before updating" It causes performance problems. See https://code.google.com/p/chromium/issues/detail?id=331076 Micro-benchmarks like http://jsperf.com/setting-document-title regress about one magnitude. We need to figure out whether the spec should change or if the CL could be written in a less performance-intrusive way, or if it's a performance penalty we accept. So revert for now. The follow-up "Inhibit title updates when removing children before setting new value" is reverted too since it has no value without the first patch. Reverted CLs: https://codereview.chromium.org/128603002 https://codereview.chromium.org/107513013 BUG=331076 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -90 lines) Patch
D LayoutTests/fast/dom/document-set-title-mutations.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/document-set-title-mutations-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/document-set-title-no-reuse.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/document-set-title-no-reuse-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/title-text-property-3.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/title-text-property-3-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTitleElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 4 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
It seems the document.title stuff was too performance demanding for little gain (spec compliance mostly). ...
6 years, 11 months ago (2014-01-14 15:51:04 UTC) #1
jochen (gone - plz use gerrit)
sadness lgtm
6 years, 11 months ago (2014-01-14 15:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/138213005/1
6 years, 11 months ago (2014-01-15 07:34:57 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 10:43:00 UTC) #4
Message was sent while issue was closed.
Change committed as 165117

Powered by Google App Engine
This is Rietveld 408576698