Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1382123003: Fix await transformation of function calls (Closed)

Created:
5 years, 2 months ago by hausner
Modified:
5 years, 2 months ago
Reviewers:
regis, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix await transformation of function calls Ensure that side effects in actual parameter lists are preserved in await’ed function calls, eg. await foo(a++, a++) BUG=24488 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c5ed2f55b7f1c8450ec9ca52dbd53f35d2f11ce2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M runtime/vm/ast_transformer.cc View 1 chunk +14 lines, -5 lines 2 comments Download
M tests/language/await_regression_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hausner
5 years, 2 months ago (2015-10-02 23:03:11 UTC) #2
hausner
updating bug info.
5 years, 2 months ago (2015-10-05 15:52:07 UTC) #3
rmacnak
lgtm
5 years, 2 months ago (2015-10-05 17:27:00 UTC) #4
hausner
Committed patchset #1 (id:1) manually as c5ed2f55b7f1c8450ec9ca52dbd53f35d2f11ce2 (presubmit successful).
5 years, 2 months ago (2015-10-05 17:31:19 UTC) #5
regis
DBC https://chromiumcodereview.appspot.com/1382123003/diff/1/runtime/vm/ast_transformer.cc File runtime/vm/ast_transformer.cc (right): https://chromiumcodereview.appspot.com/1382123003/diff/1/runtime/vm/ast_transformer.cc#newcode584 runtime/vm/ast_transformer.cc:584: result_ = Transform(node->nodes()[last_node_index]); You could have used node->nodes().Last()
5 years, 2 months ago (2015-10-05 20:33:15 UTC) #7
hausner
5 years, 2 months ago (2015-10-05 21:19:43 UTC) #8
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1382123003/diff/1/runtime/vm/ast_trans...
File runtime/vm/ast_transformer.cc (right):

https://chromiumcodereview.appspot.com/1382123003/diff/1/runtime/vm/ast_trans...
runtime/vm/ast_transformer.cc:584: result_ =
Transform(node->nodes()[last_node_index]);
On 2015/10/05 20:33:15, regis wrote:
> You could have used node->nodes().Last()

Good idea. Will do in a later checkin.

Powered by Google App Engine
This is Rietveld 408576698