Move googleurl into the Chrome repo.

Move googleurl into the Chrome repo.

Original location:
https://code.google.com/p/google-url/
This includes changes up to r184.

These files are unchanged from the Google Code repo and do not yet build.
Updating includes, etc. will be done in a separate pass.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193439

[brettw, 2013-04-08 22:59:37]

Moved directories because "Google" isn't necessary any more (that was required
for the project name) and it will prevent people from having to manually delete
the directory to unhork their repo.

[jamesr, 2013-04-09 03:43:06]

On 2013/04/08 22:59:37, brettw wrote:
> Moved directories because "Google" isn't necessary any more (that was required
> for the project name) and it will prevent people from having to manually
delete
> the directory to unhork their repo.

I see you've done this with git, which (erroneously) thinks that some of these
files are copy+modifies from other files in the repo.  I think it'd be better to
either suppress this similarity checking before landing or use an SVN checkout
for the initial land to have cleaner history.

[ericroman, 2013-04-09 07:07:58]

Have you considered moving this under either "net/url/*" or  "base/url/*" ?

[brettw, 2013-04-09 19:34:14]

Interesting, I had not considered that. It does seem nice in some respects.

There are some modules like media and WebKit that currently depend on googleurl
but not net. We also take the googleurl source and use it in various other
places, so I wouldn't want it to depend on any other parts of net.

But if we did that it seems a bit weird that net/url wouldn't depend on
net/base. So I'm still leaning toward the toplevel directory a bit.

[brettw, 2013-04-09 19:34:42]

(I don't think it belongs in base.)

[brettw, 2013-04-10 05:15:03]

New upload from svn with no weird moves.

[darin (slow to review), 2013-04-10 18:06:15]

Right, we have historically avoided adding the concept of URL to src/base/.
 I also agree that net/url/ is suboptimal since some consumers like Blink
depend on googleurl without depending on net/.

Note: importing googleurl like this means that any interface changes that
impact Blink will have to be staged very carefully so as not to break the
build.  We're creating another dependency cycle between Chromium and Blink.
 We sort of already had that before.

-Darin


On Tue, Apr 9, 2013 at 12:34 PM, <brettw@chromium.org> wrote:

> (I don't think it belongs in base.)
>
>
https://codereview.chromium.**org/13821004/<https://codereview.chromium.org/1...
>

[darin (slow to review), 2013-04-10 18:06:46]

LGTM

[brettw, 2013-04-10 19:39:08]

Yeah, this does make some significant changes marginally more difficult. But the
API has been very stable lately (we've only added FileSystem stuff) and it was
already pretty sucky.

[brettw, 2013-04-10 20:11:03]

Committed patchset #2 manually as r193439.