Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382043003: content: Add CreateGpuMemoryBufferFromHandle to GpuMemoryBufferFactory interface. (Closed)

Created:
5 years, 2 months ago by reveman
Modified:
5 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add CreateGpuMemoryBufferFromHandle to GpuMemoryBufferFactory interface. BUG=538325 Committed: https://crrev.com/a0c83f7682345086c296e8815fdca732d16664b6 Cr-Commit-Position: refs/heads/master@{#353169}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : return handle instead of bool #

Patch Set 4 : add unit test #

Patch Set 5 : iosurface fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M content/common/gpu/gpu_memory_buffer_factory.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_surface_texture.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M content/test/gpu_memory_buffer_factory_test_template.h View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1389133002 Patch 120001

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382043003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382043003/60001
5 years, 2 months ago (2015-10-07 20:29:04 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/14083)
5 years, 2 months ago (2015-10-07 20:47:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382043003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382043003/80001
5 years, 2 months ago (2015-10-08 00:22:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 01:35:23 UTC) #8
reveman
5 years, 2 months ago (2015-10-08 19:14:26 UTC) #10
piman
lgtm
5 years, 2 months ago (2015-10-08 23:09:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382043003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382043003/80001
5 years, 2 months ago (2015-10-08 23:13:08 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-08 23:21:12 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 23:22:31 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/a0c83f7682345086c296e8815fdca732d16664b6
Cr-Commit-Position: refs/heads/master@{#353169}

Powered by Google App Engine
This is Rietveld 408576698