Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 13818030: Added primary input devices setting to blink to allow media queries for hover/pointer (Closed)

Created:
7 years, 8 months ago by bokan
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, apavlov+blink_chromium.org, Alexis Menard, abarth_chromum.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added primary input devices setting to blink to allow media queries for hover/pointer Added a "primary input devices" setting in Blink to allow implementation of hover:1 and pointer:fine|none in addition to hover:0 and pointer:coarse, already implemented in http://wkb.ug/87403. This setting is a bit flag, allowing multiple devices to be specified. It indicates to Blink the available input devices that we expect the user is interacting with. This CL was started and first reviewed in http://wkb.ug/87806 BUG=136119

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -37 lines) Patch
M LayoutTests/fast/media/mq-pointer.html View 2 chunks +23 lines, -1 line 0 comments Download
M LayoutTests/fast/media/mq-pointer-expected.txt View 2 chunks +60 lines, -0 lines 0 comments Download
M Source/WebCore/css/MediaQueryEvaluator.cpp View 1 2 chunks +20 lines, -28 lines 0 comments Download
M Source/WebCore/page/Settings.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.in View 1 2 chunks +5 lines, -1 line 0 comments Download
M Source/WebCore/platform/chromium/PopupListBox.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/PopupListBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/chromium/PopupMenuChromium.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/testing/InternalSettings.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/testing/InternalSettings.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download
M Source/WebCore/testing/InternalSettings.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebSettings.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebPagePopupImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rick Byers
Using bitflags to represent the primary pointers seems like a great trade-off to me (still ...
7 years, 8 months ago (2013-04-10 14:57:50 UTC) #1
bokan
7 years, 8 months ago (2013-04-10 16:03:29 UTC) #2
https://codereview.chromium.org/13818030/diff/1/Source/WebCore/platform/chrom...
File Source/WebCore/platform/chromium/PopupListBox.h (right):

https://codereview.chromium.org/13818030/diff/1/Source/WebCore/platform/chrom...
Source/WebCore/platform/chromium/PopupListBox.h:86: bool primaryInputIsTouch;
On 2013/04/10 14:57:51, Rick Byers wrote:
> this again implies that there's only a single primary input.  I'd say instead
> 'primaryInputIncludesTouch' or even just 'usesTouchscreen'.

Done, changed to primaryInputIncludesTouch

https://codereview.chromium.org/13818030/diff/1/Source/WebCore/testing/Intern...
File Source/WebCore/testing/InternalSettings.cpp (right):

https://codereview.chromium.org/13818030/diff/1/Source/WebCore/testing/Intern...
Source/WebCore/testing/InternalSettings.cpp:489: comma_position =
pointerDevice.find(',', ix);
On 2013/04/10 14:57:51, Rick Byers wrote:
> Is there any other code here or in WTF somewhere for parsing a comma separated
> list that you can easily share with?  This is pretty trivial, but still would
be
> nice not to have explicit parsing code here if there's already some in a
common
> place.

Done, replaced with WTFString::split

https://codereview.chromium.org/13818030/diff/1/Source/WebKit/chromium/public...
File Source/WebKit/chromium/public/WebSettings.h (right):

https://codereview.chromium.org/13818030/diff/1/Source/WebKit/chromium/public...
Source/WebKit/chromium/public/WebSettings.h:59: PointerDeviceNone = 4
On 2013/04/10 14:57:51, Rick Byers wrote:
> Document that None is mutually exclusive with all the other flags (perhaps it
> should be first).  Other flags can occur in any combination (except Unkown is
of
> course not a flag).

Done.

Powered by Google App Engine
This is Rietveld 408576698