tools/telemetry/telemetry/page/page.py - Issue 13817009: [Telemetry] Make page cyclers more telemetric.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page.py

Issue 13817009: [Telemetry] Make page cyclers more telemetric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make navigate conditional Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page.py

diff --git a/tools/telemetry/telemetry/page/page.py b/tools/telemetry/telemetry/page/page.py

index d7b075c8da5aa94816a13e2460b14e7d04053fbd..1ec09e04b9c8a470df94d579e9048030cae61966 100644

--- a/tools/telemetry/telemetry/page/page.py

+++ b/tools/telemetry/telemetry/page/page.py

@@ -51,10 +51,10 @@ class Page(object):

path = self.base_dir + parsed_url.netloc + parsed_url.path

- if hasattr(self, 'serving_dirs'):

- url_base_dir = os.path.commonprefix(self.serving_dirs)

+ if hasattr(self.page_set, 'serving_dirs'):

+ url_base_dir = os.path.commonprefix(self.page_set.serving_dirs)

base_path = self.base_dir + '/' + url_base_dir

- return ([self.base_dir + '/' + d for d in self.serving_dirs],

+ return ([self.base_dir + '/' + d for d in self.page_set.serving_dirs],

path.replace(base_path, ''))

return os.path.split(path)