Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, zea+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, dcheng, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, dougw+watch_chromium.org, dbeam+watch-options_chromium.org, jennb, tapted, rouslan+autofill_chromium.org, mlamouri+watch-notifications_chromium.org, jianli, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, davidben+watch_chromium.org, michaelpg+watch-options_chromium.org, tfarina, donnd+watch_chromium.org, Dmitry Titov, yurys, jdonnelly+autofillwatch_chromium.org, plaree+watch_chromium.org, David Black, davemoore+watch_chromium.org, samarth+watch_chromium.org, estade+watch_chromium.org, peter+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h. Committed: https://crrev.com/e8082124b9e53dc516f54070fbc44cf80edcece0 Cr-Commit-Position: refs/heads/master@{#351675}

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : fix build, round 1 #

Patch Set 4 : fix build, round 2 #

Patch Set 5 : fix build, round 3 #

Patch Set 6 : fix build, round 4 #

Patch Set 7 : rebase, fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -68 lines) Patch
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/app_url_redirector_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_notifier.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_discovery_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/fetch_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 5 6 2 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_list.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_window_params.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_window_params.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 1 2 3 4 5 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/settings_window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/singleton_tabs.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/singleton_tabs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_bubble_links_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/login_ui_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/gpu/webgl_infobar_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Lei Zhang
5 years, 2 months ago (2015-09-30 05:31:29 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-09-30 15:12:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381633002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381633002/100001
5 years, 2 months ago (2015-09-30 18:35:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/105300) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-09-30 19:10:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381633002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381633002/120001
5 years, 2 months ago (2015-09-30 22:10:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/47777)
5 years, 2 months ago (2015-09-30 22:22:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381633002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381633002/120001
5 years, 2 months ago (2015-09-30 23:11:47 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 2 months ago (2015-09-30 23:46:21 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 23:47:16 UTC) #16
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/e8082124b9e53dc516f54070fbc44cf80edcece0
Cr-Commit-Position: refs/heads/master@{#351675}

Powered by Google App Engine
This is Rietveld 408576698