chrome/browser/devtools/chrome_devtools_discovery_provider.cc - Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/devtools/chrome_devtools_discovery_provider.cc

Issue 1381633002: Cleanup: IWYU for browser_navigator.h and browser_navigator_params.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, fix merge conflict Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/consumer_management_notifier.cc ('k') | chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/devtools/chrome_devtools_discovery_provider.h"	5 #include "chrome/browser/devtools/chrome_devtools_discovery_provider.h"

6	6

7 #include "chrome/browser/devtools/devtools_target_impl.h"	7 #include "chrome/browser/devtools/devtools_target_impl.h"

8 #include "chrome/browser/profiles/profile_manager.h"	8 #include "chrome/browser/profiles/profile_manager.h"

9 #include "chrome/browser/ui/browser_navigator.h"	9 #include "chrome/browser/ui/browser_navigator.h"

	10 #include "chrome/browser/ui/browser_navigator_params.h"

10	11

11 namespace {	12 namespace {

12	13

13 scoped_ptr<devtools_discovery::DevToolsTargetDescriptor>	14 scoped_ptr<devtools_discovery::DevToolsTargetDescriptor>

14 CreateNewChromeTab(const GURL& url) {	15 CreateNewChromeTab(const GURL& url) {

15 chrome::NavigateParams params(ProfileManager::GetLastUsedProfile(),	16 chrome::NavigateParams params(ProfileManager::GetLastUsedProfile(),

16 url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);	17 url, ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

17 params.disposition = NEW_FOREGROUND_TAB;	18 params.disposition = NEW_FOREGROUND_TAB;

18 chrome::Navigate(&params);	19 chrome::Navigate(&params);

19 if (!params.target_contents)	20 if (!params.target_contents)

(...skipping 20 matching lines...) Expand all Loading...
40 }	41 }

41	42

42 // static	43 // static

43 void ChromeDevToolsDiscoveryProvider::Install() {	44 void ChromeDevToolsDiscoveryProvider::Install() {

44 devtools_discovery::DevToolsDiscoveryManager* discovery_manager =	45 devtools_discovery::DevToolsDiscoveryManager* discovery_manager =

45 devtools_discovery::DevToolsDiscoveryManager::GetInstance();	46 devtools_discovery::DevToolsDiscoveryManager::GetInstance();

46 discovery_manager->AddProvider(	47 discovery_manager->AddProvider(

47 make_scoped_ptr(new ChromeDevToolsDiscoveryProvider()));	48 make_scoped_ptr(new ChromeDevToolsDiscoveryProvider()));

48 discovery_manager->SetCreateCallback(base::Bind(&CreateNewChromeTab));	49 discovery_manager->SetCreateCallback(base::Bind(&CreateNewChromeTab));

49 }	50 }

OLD	NEW