Issue 138163019: Remove unused android_experimental.

Issue 138163019: Remove unused android_experimental. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused android_experimental. Follow-up to r246093. BUG=none R=ilevy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246467

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	build/all_android.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	build/android/buildbot/bb_host_steps.py	View		2 chunks	+0 lines, -7 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

lgtm https://codereview.chromium.org/138163019/diff/1/build/android/buildbot/bb_host_steps.py File build/android/buildbot/bb_host_steps.py (right): https://codereview.chromium.org/138163019/diff/1/build/android/buildbot/bb_host_steps.py#newcode117 build/android/buildbot/bb_host_steps.py:117: parser.add_option('--experimental', action='store_true', Delete option too? IDK

6 years, 11 months ago (2014-01-22 23:37:02 UTC) #2

Nico

https://codereview.chromium.org/138163019/diff/1/build/android/buildbot/bb_host_steps.py File build/android/buildbot/bb_host_steps.py (right): https://codereview.chromium.org/138163019/diff/1/build/android/buildbot/bb_host_steps.py#newcode117 build/android/buildbot/bb_host_steps.py:117: parser.add_option('--experimental', action='store_true', On 2014/01/22 23:37:02, Isaac wrote: > Delete ...

6 years, 11 months ago (2014-01-22 23:41:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/138163019/1

6 years, 11 months ago (2014-01-22 23:42:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r246467.

Expand Messages | Collapse Messages