Remove unused android_experimental.

build/android/buildbot/bb_host_steps.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import sys
 
 import bb_utils
 import bb_annotations
 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
 from pylib import constants
 
 
 SLAVE_SCRIPTS_DIR = os.path.join(bb_utils.BB_BUILD_DIR, 'scripts', 'slave')
 VALID_HOST_TESTS = set(['check_webview_licenses', 'findbugs'])
-EXPERIMENTAL_TARGETS = ['android_experimental']
 
 DIR_BUILD_ROOT = os.path.dirname(constants.DIR_SOURCE_ROOT)
 
 # Short hand for RunCmd which is used extensively in this file.
 RunCmd = bb_utils.RunCmd
 
 
 def SrcPath(*path):
   return os.path.join(constants.DIR_SOURCE_ROOT, *path)
 
@@ skipping 27 matching lines @@
          '--build-tool=ninja',
          '--compiler=goma',
          '--target=%s' % options.target,
          '--goma-dir=%s' % bb_utils.GOMA_DIR]
   build_targets = options.build_targets.split(',')
   bb_annotations.PrintNamedStep('compile')
   for build_target in build_targets:
     RunCmd(cmd + ['--build-args=%s' % build_target],
         halt_on_failure=True,
         cwd=DIR_BUILD_ROOT)
-  if options.experimental:
-    for compile_target in EXPERIMENTAL_TARGETS:
-      bb_annotations.PrintNamedStep('Experimental Compile %s' % compile_target)
-      RunCmd(cmd + ['--build-args=%s' % compile_target],
-             flunk_on_failure=False,
-             cwd=DIR_BUILD_ROOT)
 
 
 def ZipBuild(options):
   bb_annotations.PrintNamedStep('zip_build')
   RunCmd([
       os.path.join(SLAVE_SCRIPTS_DIR, 'zip_build.py'),
       '--src-dir', constants.DIR_SOURCE_ROOT,
       '--exclude-files', 'lib.target,gen,android_webview,jingle_unittests']
       + bb_utils.EncodeProperties(options), cwd=DIR_BUILD_ROOT)
 
@@ skipping 32 matching lines @@
       ('findbugs', FindBugs),
       ('zip_build', ZipBuild)
   ]
 
 
 def GetHostStepsOptParser():
   parser = bb_utils.GetParser()
   parser.add_option('--steps', help='Comma separated list of host tests.')
   parser.add_option('--build-targets', default='All',
                     help='Comma separated list of build targets.')
   parser.add_option('--experimental', action='store_true',

[Isaac (away), 2014/01/22 23:37:02]

Delete option too?  IDK

[Nico, 2014/01/22 23:41:03]

As far as I can tell, a flag with the same name is used to activate experimental
tests too (in bb_device_steps.py), so it's not obvious to me which of the
--experimental flags in the bot configs are safe to remove :-/

                     help='Indicate whether to compile experimental targets.')
 
   return parser
 
 
 def main(argv):
   parser = GetHostStepsOptParser()
   options, args = parser.parse_args(argv[1:])
   if args:
     return sys.exit('Unused args %s' % args)
 
   setattr(options, 'target', options.factory_properties.get('target', 'Debug'))
 
   if options.steps:
     bb_utils.RunSteps(options.steps.split(','), GetHostStepCmds(), options)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))