Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1381563006: Gardening: Remove unnecessary FIXME from GeoNotifier (Closed)

Created:
5 years, 2 months ago by kihong
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, blink-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gardening: Remove unnecessary FIXME from GeoNotifier GeoNotifier is managed in Geolocation and it's only used in Geolocation and GeolocationWatcher which is also managed in Geolocation. Therefore m_geolocation in GeoNotifier is not a problem because there is no possibility to be used without Geolocation. BUG= Committed: https://crrev.com/355886195c74db484629c0d1a7113ab9751b39af Cr-Commit-Position: refs/heads/master@{#353482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael van Ouwerkerk
lgtm
5 years, 2 months ago (2015-10-09 16:53:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381563006/1
5 years, 2 months ago (2015-10-12 00:39:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/124774)
5 years, 2 months ago (2015-10-12 01:52:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381563006/1
5 years, 2 months ago (2015-10-12 01:54:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 02:32:31 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 02:33:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/355886195c74db484629c0d1a7113ab9751b39af
Cr-Commit-Position: refs/heads/master@{#353482}

Powered by Google App Engine
This is Rietveld 408576698