third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp - Issue 1381563006: Gardening: Remove unnecessary FIXME from GeoNotifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

Issue 1381563006: Gardening: Remove unnecessary FIXME from GeoNotifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp b/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

index 91351fc2f339b5a775afd3bad246281153dc8523..a1555b515b774dac35f3d4f9e932daf1bfd7192e 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

@@ -12,7 +12,6 @@

namespace blink {

GeoNotifier::GeoNotifier(Geolocation* geolocation, PositionCallback* successCallback, PositionErrorCallback* errorCallback, const PositionOptions& options)

- // FIXME : m_geolocation should be removed, it makes circular dependancy.

: m_geolocation(geolocation)

, m_successCallback(successCallback)

, m_errorCallback(errorCallback)

« no previous file with comments | « no previous file | no next file » | no next file with comments »