Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1381443002: Revert "Add output reference to gen written files." (Closed)

Created:
5 years, 2 months ago by Peter Mayo
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add output reference to gen written files." This reverts commit c497d21798caf871326443ad98bd58f546d7b38e. AKA https://codereview.chromium.org/1252403005/ TBR=dpranke@chromium.org BUG=533067 TEST=local re-run of gn gen in a few scenarios Committed: https://crrev.com/a4a5e48c471822d1c51dd00233bf3a167e00d80e Cr-Commit-Position: refs/heads/master@{#351319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M tools/gn/function_write_file.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 1 chunk +3 lines, -16 lines 0 comments Download
M tools/gn/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/scheduler.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Mayo
5 years, 2 months ago (2015-09-29 14:55:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381443002/1
5 years, 2 months ago (2015-09-29 14:55:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 15:09:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4a5e48c471822d1c51dd00233bf3a167e00d80e Cr-Commit-Position: refs/heads/master@{#351319}
5 years, 2 months ago (2015-09-29 15:10:23 UTC) #5
Dirk Pranke
5 years, 2 months ago (2015-09-29 17:03:15 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698