Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/gn/ninja_build_writer.cc

Issue 1381443002: Revert "Add output reference to gen written files." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_write_file.cc ('k') | tools/gn/scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_build_writer.cc
diff --git a/tools/gn/ninja_build_writer.cc b/tools/gn/ninja_build_writer.cc
index d27ebdcce66420b813f64cafbbdffc505809911b..50638fbb7876819438dea2b6dbe659779da72731 100644
--- a/tools/gn/ninja_build_writer.cc
+++ b/tools/gn/ninja_build_writer.cc
@@ -180,23 +180,10 @@ bool NinjaBuildWriter::RunAndWriteFile(
void NinjaBuildWriter::WriteNinjaRules() {
out_ << "rule gn\n";
out_ << " command = " << GetSelfInvocationCommand(build_settings_) << "\n";
- out_ << " description = Regenerating ninja files\n";
- out_ << " restat = 1\n\n";
+ out_ << " description = Regenerating ninja files\n\n";
- // This rule will regenerate the ninja files when any input file has changed,
- // or is missing.
- out_ << "build build.ninja";
-
- // Other files read by the build.
- EscapeOptions path_escaping;
- path_escaping.mode = ESCAPE_NINJA_COMMAND;
- std::vector<SourceFile> written_files = g_scheduler->GetWrittenFiles();
- for (const auto& written_file : written_files)
- out_ << " " << EscapeString(RebasePath(written_file.value(),
- build_settings_->build_dir(), build_settings_->root_path_utf8()),
- path_escaping, nullptr);
-
- out_ << ": gn\n"
+ // This rule will regenerate the ninja files when any input file has changed.
+ out_ << "build build.ninja: gn\n"
<< " generator = 1\n"
<< " depfile = build.ninja.d\n";
« no previous file with comments | « tools/gn/function_write_file.cc ('k') | tools/gn/scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698