Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 138143003: Support default values for POD struct fields in mojom IDL. (Closed)

Created:
6 years, 11 months ago by Matt Perry
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Support default values for POD struct fields in mojom IDL. TODO: default values for arrays and structs. BUG=320082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246424

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -7 lines) Patch
M mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 1 1 chunk +17 lines, -0 lines 1 comment Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_generator.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/bindings/parse/mojo_parser.py View 1 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/public/bindings/parse/mojo_translate.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/bindings/sample/sample_service_unittests.js View 1 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/public/tests/bindings/sample_service.mojom View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tests/bindings/sample_service_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Perry
6 years, 11 months ago (2014-01-21 23:01:35 UTC) #1
Matt Perry
6 years, 11 months ago (2014-01-21 23:02:24 UTC) #2
darin (slow to review)
LGTM https://codereview.chromium.org/138143003/diff/30001/mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl File mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl (right): https://codereview.chromium.org/138143003/diff/30001/mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl#newcode26 mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl:26: {{set_default(pf.field)|indent(2)}} Perhaps we should defer setting default values ...
6 years, 11 months ago (2014-01-21 23:47:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/138143003/30001
6 years, 11 months ago (2014-01-22 00:58:06 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, ...
6 years, 11 months ago (2014-01-22 02:55:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/138143003/30001
6 years, 11 months ago (2014-01-22 19:53:21 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 21:53:14 UTC) #7
Message was sent while issue was closed.
Change committed as 246424

Powered by Google App Engine
This is Rietveld 408576698