mojo/public/bindings/generators/mojom_generator.py - Issue 138143003: Support default values for POD struct fields in mojom IDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/mojom_generator.py

Issue 138143003: Support default values for POD struct fields in mojom IDL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/bindings/generators/mojom_generator.py

diff --git a/mojo/public/bindings/generators/mojom_generator.py b/mojo/public/bindings/generators/mojom_generator.py

index 6470dc047c3180ceb85ce59b1a17900373660c92..de02d1c25436f3d45a7aa3f1c17aea083815d432 100644

--- a/mojo/public/bindings/generators/mojom_generator.py

+++ b/mojo/public/bindings/generators/mojom_generator.py

@@ -25,8 +25,11 @@ def GetStructInfo(exported, struct):

struct.exported = exported

return struct

+def IsStringKind(kind):

+ return kind.spec == 's'

def IsObjectKind(kind):

- return isinstance(kind, (mojom.Struct, mojom.Array)) or kind.spec == 's'

+ return isinstance(kind, (mojom.Struct, mojom.Array)) or IsStringKind(kind)

def IsHandleKind(kind):

return kind.spec.startswith('h')