Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header

Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header
BUG=169182
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148318

[darin (slow to review), 2013-04-10 23:13:16]

https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/gener...
File Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (right):

https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/gener...
Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:287: #if USE(WEBP)
WTF_USE_WEBP is no longer required in Blink.  We can delete that #define.

[urvang (Google), 2013-04-11 00:42:51]

Thanks Darin! Reply inline...

https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/gener...
File Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (right):

https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/gener...
Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:287: #if USE(WEBP)
On 2013/04/10 23:13:16, darin wrote:
> WTF_USE_WEBP is no longer required in Blink.  We can delete that #define.

I was having a look at the latest tree, and WTF_USE_WEBP is still defined
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
and used elsewhere
(https://code.google.com/p/chromium/codesearch#search/&q=%22USE(WEBP)%22&sq=pa...).

Perhaps, we should have a separate change to remove all the instances at once.

[darin (slow to review), 2013-04-12 21:25:33]

OK, LGTM

I would like to see WTF_USE_WEBP removed.  I don't think we need to support that
as a compile time option.

[commit-bot: I haz the power, 2013-04-12 21:25:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/urvang@google.com/13814024/1

[commit-bot: I haz the power, 2013-04-12 21:25:52]

Failed to apply patch for
Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/WebCore/bindings
  Created missing directory Source/WebCore/bindings.
  A         Source/WebCore/bindings/generic
  Created missing directory Source/WebCore/bindings/generic.
  patching file Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
  Hunk #1 FAILED at 226.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp.rej

Patch:       Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
Index: Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
diff --git a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
index
f0f72522a3a5f9678f9155b4a4ee20db0a29d588..b40d9f6e8023ef7c771453edd4b18cb9259a437e
100644
--- a/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
+++ b/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
@@ -226,4 +226,8 @@ bool RuntimeEnabledFeatures::areSeamlessIFramesEnabled =
false;
 bool RuntimeEnabledFeatures::isFontLoadEventsEnabled = false;
 #endif
 
+#if USE(WEBP)
+bool RuntimeEnabledFeatures::isWebPInAcceptHeaderEnabled = false;
+#endif
+
 } // namespace WebCore

[urvang (Google), 2013-04-12 22:01:59]

Looks like some files have moved recently.
Here is a rebased change.

[commit-bot: I haz the power, 2013-04-12 22:04:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/urvang@google.com/13814024/9001

[commit-bot: I haz the power, 2013-04-12 23:21:14]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-04-12 23:23:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/urvang@google.com/13814024/9001

[commit-bot: I haz the power, 2013-04-13 00:22:01]

Change committed as 148318