Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1381383002: PPC: Remove register index/code indirection (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove register index/code indirection Port 5cf1c0bcf6f10ff61a95a00fa302eeee7c390885 Original commit message: Previous to this patch, both the lithium and TurboFan register allocators tracked allocated registers by "indices", rather than the register codes used elsewhere in the runtime. This patch ensures that codes are used everywhere, and in the process cleans up a bunch of redundant code and adds more structure to how the set of allocatable registers is defined. Some highlights of changes: * TurboFan's RegisterConfiguration class moved to V8's top level so that it can be shared with Crankshaft. * Various "ToAllocationIndex" and related methods removed. * Code that can be easily shared between Register classes on different platforms is now shared. * The list of allocatable registers on each platform is declared as a list rather than implicitly via the register index <-> code mapping. R=danno@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/f53fda63eb48b560bd28476158ecd5eb83c26524 Cr-Commit-Position: refs/heads/master@{#31114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -396 lines) Patch
M src/ppc/assembler-ppc.h View 4 chunks +109 lines, -273 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/ppc/constants-ppc.h View 2 chunks +3 lines, -16 lines 0 comments Download
M src/ppc/constants-ppc.cc View 2 chunks +4 lines, -40 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 6 chunks +21 lines, -17 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/frames-ppc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/register-configuration.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-02 22:46:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381383002/1
5 years, 2 months ago (2015-10-02 22:48:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 23:12:54 UTC) #5
michael_dawson
On 2015/10/02 23:12:54, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-05 13:30:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381383002/1
5 years, 2 months ago (2015-10-05 13:40:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6361)
5 years, 2 months ago (2015-10-05 13:44:14 UTC) #10
MTBrandyberry
On 2015/10/05 13:44:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-05 17:14:26 UTC) #11
danno
src/register-configuration.cc changes lgtm
5 years, 2 months ago (2015-10-05 19:18:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381383002/1
5 years, 2 months ago (2015-10-05 19:43:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 19:45:40 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 19:45:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f53fda63eb48b560bd28476158ecd5eb83c26524
Cr-Commit-Position: refs/heads/master@{#31114}

Powered by Google App Engine
This is Rietveld 408576698