Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1381353002: Revert of permissions: remove duplicates from request multiple at the Blink level (Closed)

Created:
5 years, 2 months ago by dmurph
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-permissions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of permissions: remove duplicates from request multiple at the Blink level (patchset #4 id:60001 of https://codereview.chromium.org/1360023005/ ) Reason for revert: BUG=538717 Original issue's description: > permissions: remove duplicates from request multiple at the Blink level > > Propogating this information all the way to PermissionManager so it can be handled there > seems to be a waste of time and memory. It also adds a bunch of complexity to > all PermissionManager implementations. > > Instead of this, handle all duplication at the Blink level so that chrome > can focus on handling requests. > > BUG=516626 > > Committed: https://crrev.com/b3d2e697dc79112379f96f0f34cf26b83227a737 > Cr-Commit-Position: refs/heads/master@{#352072} TBR=mlamouri@chromium.org,lalitm@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516626 Committed: https://crrev.com/274f94ac26b2c789770e9280295a4f7dc71a8be0 Cr-Commit-Position: refs/heads/master@{#352113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -39 lines) Patch
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 3 chunks +4 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionsCallback.h View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp View 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmurph
Created Revert of permissions: remove duplicates from request multiple at the Blink level
5 years, 2 months ago (2015-10-02 20:16:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381353002/1
5 years, 2 months ago (2015-10-02 20:17:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 20:21:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/274f94ac26b2c789770e9280295a4f7dc71a8be0 Cr-Commit-Position: refs/heads/master@{#352113}
5 years, 2 months ago (2015-10-02 20:21:57 UTC) #4
mlamouri (slow - plz ping)
5 years, 2 months ago (2015-10-03 14:53:02 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1381423002/ by mlamouri@chromium.org.

The reason for reverting is: Depending CL has relanded..

Powered by Google App Engine
This is Rietveld 408576698