Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 1381353002: Revert of permissions: remove duplicates from request multiple at the Blink level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-permissions
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionsCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index c0d92a1cfc34953701f3791292e0bb6ff62a8140..1e6acc2955aa3b4d4b2b90709071b412f07f32df 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -23,8 +23,6 @@
#include "platform/Logging.h"
#include "public/platform/Platform.h"
#include "public/platform/modules/permissions/WebPermissionClient.h"
-#include "wtf/NotFound.h"
-#include "wtf/Vector.h"
namespace blink {
@@ -148,8 +146,7 @@
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't request permissions."));
ExceptionState exceptionState(ExceptionState::GetterContext, "request", "Permissions", scriptState->context()->Global(), scriptState->isolate());
- OwnPtr<Vector<WebPermissionType>> internalPermissions = adoptPtr(new Vector<WebPermissionType>());
- OwnPtr<Vector<int>> callerIndexToInternalIndex = adoptPtr(new Vector<int>(rawPermissions.size()));
+ OwnPtr<WebVector<WebPermissionType>> permissions = adoptPtr(new WebVector<WebPermissionType>(rawPermissions.size()));
for (size_t i = 0; i < rawPermissions.size(); ++i) {
const Dictionary& rawPermission = rawPermissions[i];
@@ -157,25 +154,14 @@
if (exceptionState.hadException())
return exceptionState.reject(scriptState);
- // Only append permissions to the vector that is passed to the client if it is not already
- // in the vector (i.e. do not duplicate permisison types).
- int internalIndex;
- auto it = internalPermissions->find(type.get());
- if (it == kNotFound) {
- internalIndex = internalPermissions->size();
- internalPermissions->append(type.get());
- } else {
- internalIndex = it;
- }
- callerIndexToInternalIndex->operator[](i) = internalIndex;
+ permissions->operator[](i) = type.get();
}
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
- WebVector<WebPermissionType> internalWebPermissions = *internalPermissions;
- client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()),
- new PermissionsCallback(resolver, internalPermissions.release(), callerIndexToInternalIndex.release()));
+ WebVector<WebPermissionType> permissionsCopy = *permissions;
+ client->requestPermissions(permissionsCopy, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionsCallback(resolver, permissions.release()));
return promise;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionsCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698