Make layout test FreeType more like Lucid FreeType.

Make layout test FreeType more like Lucid FreeType.

The patch set to Lucid's FreeType defines TT_CONFIG_OPTION_BYTECODE_INTERPRETER.
This change does so for the layout test's build of FreeType.

R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246126

[bungeman-chromium, 2014-01-21 19:04:55]

In the README.chromium it states that this FreeType is supposed to mirror that
of Ubuntu Lucid, but Lucid has a number of additional patches. See
https://launchpad.net/ubuntu/+source/freetype/2.3.11-1ubuntu2.7 , look at the
diff.gz , and then search for
freetype-2.3.11.orig/debian/patches-freetype/freetype-bytecode-interpreter.patch
.

The one in question here is enabling bytecode hinting. This is needed so that we
can land the Skia change at https://codereview.chromium.org/139943004/ to fix
some long outstanding issues around respecting user settings on Linux (in
particular, system settings on ChromeOS). Without this change, the linked CL
causes a very large number of layout test failures as it correctly does not
force the autohinter off. With this change the only test affected by the linked
CL is fast/text/chromium-linux-fontconfig-renderstyle.html which is improved.

I tried running the _blink bots against this change, but apparently they aren't
rooted in the same place (causing the patch to fail). I'm not as familiar with
those bots as of yet.

[Dirk Pranke, 2014-01-21 19:52:57]

So, to dust off my memory here, the new ftoption.h file is the same as the
ftoption.h in src/include/freetype/config except with the patch applied, right?

If so, lgtm.

I'm a bit surprised that I missed an option before; I was pretty sure that I had
done a diff of the two packages, but maybe I missed something.

[bungeman-chromium, 2014-01-21 20:03:08]

On 2014/01/21 19:52:57, Dirk Pranke wrote:
> So, to dust off my memory here, the new ftoption.h file is the same as the
> ftoption.h in src/include/freetype/config except with the patch applied,
right?
> 
> If so, lgtm.
> 
> I'm a bit surprised that I missed an option before; I was pretty sure that I
had
> done a diff of the two packages, but maybe I missed something.

Yes, that's exactly what I did, in fact. Copied
src/include/freetype/config/ftoption.h to include/ and applied
freetype-2.3.11.orig/debian/patches-freetype/freetype-bytecode-interpreter.patch
from the Ubuntu Lucid repo. There appear to possibly be other patches we don't
have in the freetype_2.3.11-1ubuntu2.diff.gz as well. However, this is the only
one I really need at the moment, and it appears one could sink an awful lot of
time into this sort of thing.

[Dirk Pranke, 2014-01-21 20:31:54]

Oh, and you won't be able to run the layout tests against this patch on the try
servers; we don't have a way of running the layout tests w/ chromium patches,
unfortunately (this is crbug.com/259421).

[bungeman-chromium, 2014-01-21 21:45:33]

Committed patchset #4 manually as r246126 (presubmit successful).