Issue 13812014: Added check for icons that change.

Issue 13812014: Added check for icons that change. (Closed)

Created:
7 years, 8 months ago by shatch

Modified:
7 years, 8 months ago

Reviewers:
Robert Sesek, Nico

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Skip the cached icons if the icon can change (ie. exe/dll/ico on Windows). BUG=226918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193259

Patch Set 2 : Changes from review. #

Total comments: 1

Patch Set 3 : Changes from review. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
M	chrome/browser/icon_loader.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/icon_loader.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/icon_loader_android.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/icon_loader_chromeos.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/icon_loader_linux.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/icon_loader_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/icon_loader_win.cc	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nico

Looks like rsesek reviewed https://chromiumcodereview.appspot.com/12211049/ , maybe he can give this a first look :-)

7 years, 8 months ago (2013-04-09 19:33:41 UTC) #2

Robert Sesek

https://codereview.chromium.org/13812014/diff/1/chrome/browser/icon_loader_win.cc File chrome/browser/icon_loader_win.cc (right): https://codereview.chromium.org/13812014/diff/1/chrome/browser/icon_loader_win.cc#newcode28 chrome/browser/icon_loader_win.cc:28: if (extension == L".exe" || extension == L".dll" || ...

7 years, 8 months ago (2013-04-09 20:13:58 UTC) #3

shatch

New snapshot uploaded. https://codereview.chromium.org/13812014/diff/1/chrome/browser/icon_loader_win.cc File chrome/browser/icon_loader_win.cc (right): https://codereview.chromium.org/13812014/diff/1/chrome/browser/icon_loader_win.cc#newcode28 chrome/browser/icon_loader_win.cc:28: if (extension == L".exe" || extension ...

7 years, 8 months ago (2013-04-09 20:43:25 UTC) #4

Robert Sesek

LGTM https://codereview.chromium.org/13812014/diff/6001/chrome/browser/icon_loader_win.cc File chrome/browser/icon_loader_win.cc (right): https://codereview.chromium.org/13812014/diff/6001/chrome/browser/icon_loader_win.cc#newcode28 chrome/browser/icon_loader_win.cc:28: return (extension == L".exe" || nit: no () ...

7 years, 8 months ago (2013-04-09 20:44:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/13812014/8001

7 years, 8 months ago (2013-04-09 21:16:54 UTC) #7

Message was sent while issue was closed.

Change committed as 193259

Expand Messages | Collapse Messages