chrome/browser/icon_loader.cc - Issue 13812014: Added check for icons that change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/icon_loader.cc

Issue 13812014: Added check for icons that change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/icon_loader.cc

diff --git a/chrome/browser/icon_loader.cc b/chrome/browser/icon_loader.cc

index 6e16d0cdfc0b91ad5a51037a34c03eb502ee409c..f8ea311b51257e4787f60c617f9d59ca978f35d9 100644

--- a/chrome/browser/icon_loader.cc

+++ b/chrome/browser/icon_loader.cc

@@ -35,7 +35,8 @@ void IconLoader::ReadGroup() {

}

void IconLoader::OnReadGroup() {

- if (!delegate_->OnGroupLoaded(this, group_)) {

+ if (IsIconMutableFromFilepath(file_path_) ||

+ !delegate_->OnGroupLoaded(this, group_)) {

BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,

base::Bind(&IconLoader::ReadIcon, this));

}

« no previous file with comments | « chrome/browser/icon_loader.h ('k') | chrome/browser/icon_loader_android.cc » ('j') | no next file with comments »