Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 13812011: Fix KeyedAccessStoreMode on Windows (Closed)

Created:
7 years, 8 months ago by danno
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix KeyedAccessStoreMode on Windows R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14189

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/ast.h View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
7 years, 8 months ago (2013-04-09 16:10:21 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/13812011/diff/1/src/ast.h File src/ast.h (right): https://codereview.chromium.org/13812011/diff/1/src/ast.h#newcode1814 src/ast.h:1814: KeyedAccessStoreMode store_mode_: 5; Let's add a ...
7 years, 8 months ago (2013-04-09 16:18:20 UTC) #2
danno
7 years, 8 months ago (2013-04-09 16:26:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698