Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/ast.h

Issue 13812011: Fix KeyedAccessStoreMode on Windows (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1793 matching lines...) Expand 10 before | Expand all | Expand 10 after
1804 store_mode_(STANDARD_STORE), 1804 store_mode_(STANDARD_STORE),
1805 expression_(expr), 1805 expression_(expr),
1806 pos_(pos), 1806 pos_(pos),
1807 assignment_id_(GetNextId(isolate)), 1807 assignment_id_(GetNextId(isolate)),
1808 count_id_(GetNextId(isolate)) {} 1808 count_id_(GetNextId(isolate)) {}
1809 1809
1810 private: 1810 private:
1811 Token::Value op_; 1811 Token::Value op_;
1812 bool is_prefix_ : 1; 1812 bool is_prefix_ : 1;
1813 bool is_monomorphic_ : 1; 1813 bool is_monomorphic_ : 1;
1814 KeyedAccessStoreMode store_mode_: 4; 1814 KeyedAccessStoreMode store_mode_ : 5; // Windows treats as signed,
1815 // must have extra bit.
1815 Expression* expression_; 1816 Expression* expression_;
1816 int pos_; 1817 int pos_;
1817 const BailoutId assignment_id_; 1818 const BailoutId assignment_id_;
1818 const TypeFeedbackId count_id_; 1819 const TypeFeedbackId count_id_;
1819 SmallMapList receiver_types_; 1820 SmallMapList receiver_types_;
1820 }; 1821 };
1821 1822
1822 1823
1823 class CompareOperation: public Expression { 1824 class CompareOperation: public Expression {
1824 public: 1825 public:
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
1946 1947
1947 private: 1948 private:
1948 Token::Value op_; 1949 Token::Value op_;
1949 Expression* target_; 1950 Expression* target_;
1950 Expression* value_; 1951 Expression* value_;
1951 int pos_; 1952 int pos_;
1952 BinaryOperation* binary_operation_; 1953 BinaryOperation* binary_operation_;
1953 const BailoutId assignment_id_; 1954 const BailoutId assignment_id_;
1954 1955
1955 bool is_monomorphic_ : 1; 1956 bool is_monomorphic_ : 1;
1956 KeyedAccessStoreMode store_mode_ : 4; 1957 KeyedAccessStoreMode store_mode_ : 5; // Windows treats as signed,
1958 // must have extra bit.
1957 SmallMapList receiver_types_; 1959 SmallMapList receiver_types_;
1958 }; 1960 };
1959 1961
1960 1962
1961 class Yield: public Expression { 1963 class Yield: public Expression {
1962 public: 1964 public:
1963 DECLARE_NODE_TYPE(Yield) 1965 DECLARE_NODE_TYPE(Yield)
1964 1966
1965 Expression* expression() const { return expression_; } 1967 Expression* expression() const { return expression_; }
1966 bool is_delegating_yield() const { return is_delegating_yield_; } 1968 bool is_delegating_yield() const { return is_delegating_yield_; }
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
3014 private: 3016 private:
3015 Isolate* isolate_; 3017 Isolate* isolate_;
3016 Zone* zone_; 3018 Zone* zone_;
3017 Visitor visitor_; 3019 Visitor visitor_;
3018 }; 3020 };
3019 3021
3020 3022
3021 } } // namespace v8::internal 3023 } } // namespace v8::internal
3022 3024
3023 #endif // V8_AST_H_ 3025 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698