Issue 13812005: net: move socket files from net/base to net/socket

Issue 13812005: net: move socket files from net/base to net/socket (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.

Modified:
7 years, 8 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, bulach+watch_chromium.org, tfarina, amit, frankf+watch_chromium.org, jam, yurys, ilevy+watch_chromium.org, joi+watch-content_chromium.org, sail+watch_chromium.org, robertshield, jochen+watch_chromium.org, grt+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, native-client-reviews_googlegroups.com, android-webview-reviews_chromium.org, pfeldman, yfriedman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: move socket files from net/base to net/socket BUG=70818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192982

Patch Set 1 #

Total comments: 4

Patch Set 2 : sort gyp #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -1751 lines)			Patch
M	android_webview/browser/aw_devtools_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/dev_tools_server.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/devtools_sanity_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/devtools/remote_debugging_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/test_server/http_connection.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google_apis/test_server/http_server.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/net/net_util_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/net/test_http_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_server.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/test/test_with_web_server.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/devtools/devtools_http_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/shell_devtools_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	net/base/stream_listen_socket.h	View		1 chunk	+0 lines, -155 lines	0 comments	Download
D	net/base/stream_listen_socket.cc	View		1 chunk	+0 lines, -303 lines	0 comments	Download
D	net/base/tcp_listen_socket.h	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	net/base/tcp_listen_socket.cc	View		1 chunk	+0 lines, -128 lines	0 comments	Download
D	net/base/tcp_listen_socket_unittest.h	View		1 chunk	+0 lines, -122 lines	0 comments	Download
D	net/base/tcp_listen_socket_unittest.cc	View		1 chunk	+0 lines, -296 lines	0 comments	Download
D	net/base/unix_domain_socket_posix.h	View		1 chunk	+0 lines, -120 lines	0 comments	Download
D	net/base/unix_domain_socket_posix.cc	View		1 chunk	+0 lines, -186 lines	0 comments	Download
D	net/base/unix_domain_socket_posix_unittest.cc	View		1 chunk	+0 lines, -313 lines	0 comments	Download
M	net/net.gyp	View	1	7 chunks	+10 lines, -10 lines	0 comments	Download
M	net/server/http_connection.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/server/http_server.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/server/http_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	net/socket/stream_listen_socket.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	net/socket/stream_listen_socket.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	net/socket/tcp_listen_socket.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	net/socket/tcp_listen_socket.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	net/socket/tcp_listen_socket_unittest.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	net/socket/tcp_listen_socket_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/transport_client_socket_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	net/socket/unix_domain_socket_posix.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	net/socket/unix_domain_socket_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	net/socket/unix_domain_socket_posix_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/fetch/http_listen_socket.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/android/forwarder2/socket.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

If the move looks good to you, I'll do the usual fix-ups (sorting in gyp ...

7 years, 8 months ago (2013-04-08 22:14:05 UTC) #1

eroman

lgtm https://codereview.chromium.org/13812005/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/13812005/diff/1/net/net.gyp#newcode213 net/net.gyp:213: 'socket/stream_listen_socket.cc', please re-order these. https://codereview.chromium.org/13812005/diff/1/net/net.gyp#newcode1410 net/net.gyp:1410: 'socket/tcp_listen_socket_unittest.cc', please ...

7 years, 8 months ago (2013-04-08 22:36:30 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/13812005/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/13812005/diff/1/net/net.gyp#newcode213 net/net.gyp:213: 'socket/stream_listen_socket.cc', On 2013/04/08 22:36:31, eroman wrote: > please re-order ...

7 years, 8 months ago (2013-04-09 01:11:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r192982.

Expand Messages | Collapse Messages