chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

index 6c1a32d0d6d75f86703f20e74dd9a043068b9327..168fc12d466ae40df723485c62e9bd6190c11a93 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

@@ -173,14 +173,16 @@ public interface TabObserver {

* staying in the same html document, {@link #onLoadStarted(Tab)} will be called, while

* {@link #onPageLoadStarted(Tab, String)} will not.

* @param tab The notifying {@link Tab}.

+ * @param toDifferentDocument Whether this navigation will transition between

+ * documents (i.e., not a fragment navigation or JS History API call).

- void onLoadStarted(Tab tab);

+ void onLoadStarted(Tab tab, boolean toDifferentDocument);

/**

* Called when the contents loading stops.

* @param tab The notifying {@link Tab}.

- void onLoadStopped(Tab tab);

+ void onLoadStopped(Tab tab, boolean toDifferentDocument);

/**

* Called when the load progress of a {@link Tab} changes.