Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.tab; 5 package org.chromium.chrome.browser.tab;
6 6
7 import android.view.ContextMenu; 7 import android.view.ContextMenu;
8 8
9 import org.chromium.chrome.browser.TabLoadStatus; 9 import org.chromium.chrome.browser.TabLoadStatus;
10 import org.chromium.content.browser.ContentViewCore; 10 import org.chromium.content.browser.ContentViewCore;
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 void onWebContentsInstantSupportDisabled(); 166 void onWebContentsInstantSupportDisabled();
167 167
168 // WebContentsDelegateAndroid methods -------------------------------------- ------------------- 168 // WebContentsDelegateAndroid methods -------------------------------------- -------------------
169 169
170 /** 170 /**
171 * Called when the WebContents starts loading. Different from 171 * Called when the WebContents starts loading. Different from
172 * {@link #onPageLoadStarted(Tab, String)}, if the user is navigated to a di fferent url while 172 * {@link #onPageLoadStarted(Tab, String)}, if the user is navigated to a di fferent url while
173 * staying in the same html document, {@link #onLoadStarted(Tab)} will be ca lled, while 173 * staying in the same html document, {@link #onLoadStarted(Tab)} will be ca lled, while
174 * {@link #onPageLoadStarted(Tab, String)} will not. 174 * {@link #onPageLoadStarted(Tab, String)} will not.
175 * @param tab The notifying {@link Tab}. 175 * @param tab The notifying {@link Tab}.
176 * @param toDifferentDocument Whether this navigation will transition betwee n
177 * documents (i.e., not a fragment navigation or JS History API call).
176 */ 178 */
177 void onLoadStarted(Tab tab); 179 void onLoadStarted(Tab tab, boolean toDifferentDocument);
178 180
179 /** 181 /**
180 * Called when the contents loading stops. 182 * Called when the contents loading stops.
181 * @param tab The notifying {@link Tab}. 183 * @param tab The notifying {@link Tab}.
182 */ 184 */
183 void onLoadStopped(Tab tab); 185 void onLoadStopped(Tab tab, boolean toDifferentDocument);
184 186
185 /** 187 /**
186 * Called when the load progress of a {@link Tab} changes. 188 * Called when the load progress of a {@link Tab} changes.
187 * @param tab The notifying {@link Tab}. 189 * @param tab The notifying {@link Tab}.
188 * @param progress The new progress from [0,100]. 190 * @param progress The new progress from [0,100].
189 */ 191 */
190 void onLoadProgressChanged(Tab tab, int progress); 192 void onLoadProgressChanged(Tab tab, int progress);
191 193
192 /** 194 /**
193 * Called when the URL of a {@link Tab} changes. 195 * Called when the URL of a {@link Tab} changes.
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 * @param tab The notifying {@link Tab}. 308 * @param tab The notifying {@link Tab}.
307 * @param sourceWebContents The {@link WebContents} that triggered the cre ation. 309 * @param sourceWebContents The {@link WebContents} that triggered the cre ation.
308 * @param openerRenderFrameId The opener render frame id. 310 * @param openerRenderFrameId The opener render frame id.
309 * @param frameName The name of the frame. 311 * @param frameName The name of the frame.
310 * @param targetUrl The target url. 312 * @param targetUrl The target url.
311 * @param newWebContents The newly created {@link WebContents}. 313 * @param newWebContents The newly created {@link WebContents}.
312 */ 314 */
313 public void webContentsCreated(Tab tab, WebContents sourceWebContents, long openerRenderFrameId, 315 public void webContentsCreated(Tab tab, WebContents sourceWebContents, long openerRenderFrameId,
314 String frameName, String targetUrl, WebContents newWebContents); 316 String frameName, String targetUrl, WebContents newWebContents);
315 } 317 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698