Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't pulse progress bar for same-document navs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index 3d74cb934588cbd29a339a7ba551c25aa2a8e1b3..fbfb8b9605c402dfbefe15e9d09fb2d111942701 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -132,9 +132,9 @@ public class OverlayPanelContent {
mWebContentsDelegate = new WebContentsDelegateAndroid() {
@Override
- public void onLoadStarted() {
- super.onLoadStarted();
- mProgressObserver.onProgressBarStarted();
+ public void onLoadStarted(boolean toDifferentDocument) {
+ super.onLoadStarted(toDifferentDocument);
+ if (toDifferentDocument) mProgressObserver.onProgressBarStarted();
Ted C 2015/10/28 23:41:02 this wasn't guarded before by toDifferentDocument,
Nate Chapin 2015/10/30 20:41:34 Yeah, I saw "onProgressBarStarted" and went into a
}
@Override

Powered by Google App Engine
This is Rietveld 408576698