Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't pulse progress bar for same-document navs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
index 44751a6bed40124402e54f61006b8f749c7e2ce8..39377e138927e3632ad316b5648e142e1227ce0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
@@ -254,8 +254,8 @@ public class LayoutManagerChrome
mTabSelectorTabObserver = new TabModelSelectorTabObserver(selector) {
@Override
- public void onLoadStarted(Tab tab) {
- tabLoadStarted(tab.getId(), tab.isIncognito());
+ public void onLoadStarted(Tab tab, boolean toDifferentDocument) {
+ if (toDifferentDocument) tabLoadStarted(tab.getId(), tab.isIncognito());
Ted C 2015/10/28 23:41:02 same comment
Nate Chapin 2015/10/30 20:41:34 Done.
}
@Override
« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698