Issue 138073006: sync: fix the way extension/app settings trigger deferred sync init

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138073006: sync: fix the way extension/app settings trigger deferred sync init (Closed)

Created:
6 years, 11 months ago by tim (not reviewing)

Modified:
6 years, 11 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: fix the way extension/app settings trigger deferred sync init Instead of initiating sync startup during initialization of the SettingsBackend, only do so when an actual change takes place, which was the original intent of https://codereview.chromium.org/15404005 BUG=80194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245157

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -11 lines)			Patch
M	chrome/browser/extensions/api/storage/settings_backend.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/api/storage/syncable_settings_storage.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/storage/syncable_settings_storage.cc	View	2 chunks	+15 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/138073006/diff/30001/chrome/browser/extensions/api/storage/syncable_settings_storage.cc File chrome/browser/extensions/api/storage/syncable_settings_storage.cc (right): https://codereview.chromium.org/138073006/diff/30001/chrome/browser/extensions/api/storage/syncable_settings_storage.cc#newcode138 chrome/browser/extensions/api/storage/syncable_settings_storage.cc:138: flare_.Run(sync_type_); and it's ok to ignore the changes ...

6 years, 11 months ago (2014-01-15 18:39:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/138073006/30001

6 years, 11 months ago (2014-01-15 21:29:53 UTC) #3

Message was sent while issue was closed.

Change committed as 245157

Expand Messages | Collapse Messages