sync: deferred initialization support for app/extension settings

sync: deferred initialization support for app/extension settings

BUG=80194
R=kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201137

[tim (not reviewing), 2013-05-19 19:54:19]

Hey Ben, please review.

You can ignore sync_start_util.cc, it is being reviewed separately in
https://codereview.chromium.org/15408004/, and I'll rebase this once that lands
(meaning it won't be part of the commit, but is temporarily here so that trybot
tests pass).

[not at google - send to devlin, 2013-05-20 18:00:04]

lgtm

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
File chrome/browser/extensions/api/storage/settings_backend.cc (right):

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
chrome/browser/extensions/api/storage/settings_backend.cc:77:
flare_.Run(sync_type_);
what does this actually do? will it call MergeDataAndStartSyncing? synchronously
or asynchronously? a brief comment would be nice to readers.

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
File chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc
(right):

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc:114:
sync_start_util::GetFlareForSyncableService(profile_path));
it looks like the flare can be a constructor parameter?

[tim (not reviewing), 2013-05-20 18:21:15]

Thanks for the review.

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
File chrome/browser/extensions/api/storage/settings_backend.cc (right):

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
chrome/browser/extensions/api/storage/settings_backend.cc:77:
flare_.Run(sync_type_);
On 2013/05/20 18:00:04, kalman wrote:
> what does this actually do? will it call MergeDataAndStartSyncing?
synchronously
> or asynchronously? a brief comment would be nice to readers.

Done.

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
File chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc
(right):

https://codereview.chromium.org/15404005/diff/9002/chrome/browser/extensions/...
chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc:114:
sync_start_util::GetFlareForSyncableService(profile_path));
On 2013/05/20 18:00:04, kalman wrote:
> it looks like the flare can be a constructor parameter?

Good point, done.

[commit-bot: I haz the power, 2013-05-20 18:38:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/15404005/20001

[commit-bot: I haz the power, 2013-05-20 19:56:18]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[tim (not reviewing), 2013-05-20 20:47:45]

Committed patchset #4 manually as r201137 (presubmit successful).