Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3428)

Issue 1380693004: [Sync] Fixing sync_driver lint violations and adding PRESUBMIT lint check. (Closed)

Created:
5 years, 2 months ago by skym
Modified:
5 years, 2 months ago
Reviewers:
stanisc
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cross
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fixing sync_driver lint violations and adding PRESUBMIT lint check. BUG= Committed: https://crrev.com/9dbfbcfb190f3c0ba60925edd3548b195197ef63 Cr-Commit-Position: refs/heads/master@{#353340}

Patch Set 1 : #

Patch Set 2 : Removing lint fixes for revisit files, removing revisit patch dep. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -111 lines) Patch
A + components/sync_driver/PRESUBMIT.py View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/backend_migrator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/backend_migrator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/backup_rollback_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/backup_rollback_controller_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/change_processor_mock.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/data_type_controller.h View 1 1 chunk +14 lines, -14 lines 0 comments Download
M components/sync_driver/data_type_encryption_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/data_type_error_handler_mock.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/data_type_manager_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/data_type_manager_impl_unittest.cc View 1 3 chunks +10 lines, -10 lines 0 comments Download
M components/sync_driver/data_type_status_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/device_info_sync_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync_driver/device_info_sync_service_unittest.cc View 13 chunks +24 lines, -21 lines 0 comments Download
M components/sync_driver/device_info_tracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/fake_data_type_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/fake_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/fake_generic_change_processor.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/fake_sync_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/favicon_cache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/favicon_cache_unittest.cc View 30 chunks +39 lines, -39 lines 0 comments Download
M components/sync_driver/frontend_data_type_controller_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/generic_change_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/generic_change_processor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/glue/typed_url_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/invalidation_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/invalidation_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/local_device_info_provider_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/local_device_info_provider_mock.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_driver/model_association_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/model_association_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M components/sync_driver/pref_names.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/sync_driver/profile_sync_auth_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/proxy_data_type_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/shared_change_processor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/shared_change_processor_ref.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync_driver/shared_change_processor_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/sync_api_component_factory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/sync_frontend.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/sync_prefs.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync_driver/sync_prefs_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/sync_stopped_reporter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/sync_stopped_reporter_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/system_encryptor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/system_encryptor_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/tab_node_pool_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_driver/ui_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
skym
5 years, 2 months ago (2015-10-01 17:26:54 UTC) #3
stanisc
lgtm
5 years, 2 months ago (2015-10-02 04:07:57 UTC) #4
skym
I initially had these changes depending on the typed urls revisit logic CL that eventually ...
5 years, 2 months ago (2015-10-09 16:13:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380693004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380693004/40001
5 years, 2 months ago (2015-10-09 18:28:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-09 18:44:40 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 18:45:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dbfbcfb190f3c0ba60925edd3548b195197ef63
Cr-Commit-Position: refs/heads/master@{#353340}

Powered by Google App Engine
This is Rietveld 408576698