Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/sync_driver/glue/typed_url_model_associator.cc

Issue 1380693004: [Sync] Fixing sync_driver lint violations and adding PRESUBMIT lint check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cross
Patch Set: Removing lint fixes for revisit files, removing revisit patch dep. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/glue/typed_url_model_associator.cc
diff --git a/components/sync_driver/glue/typed_url_model_associator.cc b/components/sync_driver/glue/typed_url_model_associator.cc
index 51c3bd4e2dceeb2351ec47c131f3f88665fe5bd6..8da6d60bc05c4ee4a44e4a45ea4454b41a492bf1 100644
--- a/components/sync_driver/glue/typed_url_model_associator.cc
+++ b/components/sync_driver/glue/typed_url_model_associator.cc
@@ -286,7 +286,7 @@ syncer::SyncError TypedUrlModelAssociator::DoAssociateModels(
}
// Should never be possible to delete all the items, since the
// visit vector contains all the items in typed_url.visits.
- DCHECK(visits.size() > 0);
+ DCHECK_GT(visits.size(), 0u);
}
DCHECK_EQ(new_url.last_visit().ToInternalValue(),
visits.back().visit_time.ToInternalValue());
@@ -733,7 +733,7 @@ void TypedUrlModelAssociator::WriteToTypedUrlSpecifics(
// the history DB has an inaccurate count for some reason (there's been
// bugs in the history code in the past which has left users in the wild
// with incorrect counts - http://crbug.com/84258).
- DCHECK(typed_count > 0);
+ DCHECK_GT(typed_count, 0);
if (typed_count > kMaxTypedUrlVisits) {
only_typed = true;
« no previous file with comments | « components/sync_driver/generic_change_processor_unittest.cc ('k') | components/sync_driver/invalidation_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698