Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1380543002: On Document disposal, only dispose of script runner. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On Document disposal, only dispose of script runner. Reinstate the invariant that a Document always has a ScriptRunner (m_scriptRunner), even after the document has been dispose()d. The reason for disposing the Document's ScriptRunner is to clear out back references that would otherwise cause the Document to leak. Do just that, but don't destruct the now-empty ScriptRunner object. R=haraken BUG=536796 Committed: https://crrev.com/9f0ccc18cedb41d2c1bbc4168f46c57a94451723 Cr-Commit-Position: refs/heads/master@{#351385}

Patch Set 1 #

Patch Set 2 : revert static method #

Messages

Total messages: 11 (4 generated)
sof
please take a look.
5 years, 2 months ago (2015-09-29 15:36:50 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-09-29 15:45:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380543002/20001
5 years, 2 months ago (2015-09-29 17:49:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/110354)
5 years, 2 months ago (2015-09-29 19:29:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380543002/20001
5 years, 2 months ago (2015-09-29 19:31:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 20:10:48 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 20:11:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f0ccc18cedb41d2c1bbc4168f46c57a94451723
Cr-Commit-Position: refs/heads/master@{#351385}

Powered by Google App Engine
This is Rietveld 408576698