third_party/WebKit/Source/core/dom/Document.cpp - Issue 1380543002: On Document disposal, only dispose of script runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1380543002: On Document disposal, only dispose of script runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert static method Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/script-element-moved-from-disposed-document-crash-expected.txt ('k') | third_party/WebKit/Source/core/dom/ScriptRunner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 98cd8dd6a9e2cff06694ae5b82d463c4df0a3985..0ae0dbdba8411911a6d9a40551c5435e57afbe7f 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -575,7 +575,7 @@ void Document::dispose()

m_userActionElements.documentDidRemoveLastRef();

m_associatedFormControls.clear();

- m_scriptRunner.clear();

+ m_scriptRunner->dispose();

detachParser();

m_registrationContext.clear();