Make global variable g_testing_build_time lazily created

chrome/browser/ssl/ssl_error_classification.cc

Index: chrome/browser/ssl/ssl_error_classification.cc
diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc
index ce43de58f01540d1d76c3a8cf4cddfe05df21f28..32684a466d205c164361b01a02160d05c67594e6 100644
--- a/chrome/browser/ssl/ssl_error_classification.cc
+++ b/chrome/browser/ssl/ssl_error_classification.cc
@@ -7,6 +7,7 @@
 #include "chrome/browser/ssl/ssl_error_classification.h"
 
 #include "base/build_time.h"
+#include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
@@ -117,7 +118,7 @@ int GetLevensteinDistance(const std::string& str1,
 }
 
 // The time to use when doing build time operations in browser tests.
-base::Time g_testing_build_time;
+base::LazyInstance<base::Time> g_testing_build_time = LAZY_INSTANCE_INITIALIZER;

[Mustafa Acer, 2015/09/29 15:44:25]

This could also simply be the timestamp in seconds, like uint64. That's actually
how it is in browser/ssl/ssl_error_handler so I think we should make them
consistent.

 
 } // namespace
 
@@ -241,8 +242,8 @@ void SSLErrorClassification::RecordUMAStatistics(
 
 bool SSLErrorClassification::IsUserClockInThePast(const base::Time& time_now) {
   base::Time build_time;
-  if (!g_testing_build_time.is_null()) {
-    build_time = g_testing_build_time;
+  if (!g_testing_build_time.Get().is_null()) {
+    build_time = g_testing_build_time.Get();
   } else {
 #if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
     return false;
@@ -259,8 +260,8 @@ bool SSLErrorClassification::IsUserClockInThePast(const base::Time& time_now) {
 bool SSLErrorClassification::IsUserClockInTheFuture(
     const base::Time& time_now) {
   base::Time build_time;
-  if (!g_testing_build_time.is_null()) {
-    build_time = g_testing_build_time;
+  if (!g_testing_build_time.Get().is_null()) {
+    build_time = g_testing_build_time.Get();
   } else {
 #if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
     return false;
@@ -277,7 +278,7 @@ bool SSLErrorClassification::IsUserClockInTheFuture(
 // static
 void SSLErrorClassification::SetBuildTimeForTesting(
     const base::Time& testing_time) {
-  g_testing_build_time = testing_time;
+  g_testing_build_time.Get() = testing_time;
 }
 
 bool SSLErrorClassification::MaybeWindowsLacksSHA256Support() {