Make global variable g_testing_build_time lazily created

chrome/browser/ssl/ssl_error_classification.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "chrome/browser/ssl/ssl_error_classification.h"
 
 #include "base/build_time.h"
+#include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/ssl_errors/error_info.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 90 matching lines @@
       kSecondRow[j+1] = std::min(std::min(
           kSecondRow[j] + 1, kFirstRow[j + 1] + 1), kFirstRow[j] + cost);
     }
     for (size_t j = 0; j < kFirstRow.size(); j++)
       kFirstRow[j] = kSecondRow[j];
   }
   return kSecondRow[str2.size()];
 }
 
 // The time to use when doing build time operations in browser tests.
-base::Time g_testing_build_time;
+base::LazyInstance<base::Time> g_testing_build_time = LAZY_INSTANCE_INITIALIZER;

[Mustafa Acer, 2015/09/29 15:44:25]

This could also simply be the timestamp in seconds, like uint64. That's actually
how it is in browser/ssl/ssl_error_handler so I think we should make them
consistent.

 
 } // namespace
 
 SSLErrorClassification::SSLErrorClassification(
     content::WebContents* web_contents,
     const base::Time& current_time,
     const GURL& url,
     int cert_error,
     const net::X509Certificate& cert)
   : web_contents_(web_contents),
@@ skipping 103 matching lines @@
     default:
       break;
   }
   UMA_HISTOGRAM_ENUMERATION("interstitial.ssl.connection_type",
                             net::NetworkChangeNotifier::GetConnectionType(),
                             net::NetworkChangeNotifier::CONNECTION_LAST);
 }
 
 bool SSLErrorClassification::IsUserClockInThePast(const base::Time& time_now) {
   base::Time build_time;
-  if (!g_testing_build_time.is_null()) {
-    build_time = g_testing_build_time;
+  if (!g_testing_build_time.Get().is_null()) {
+    build_time = g_testing_build_time.Get();
   } else {
 #if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
     return false;
 #else
     build_time = base::GetBuildTime();
 #endif
   }
 
   if (time_now < build_time - base::TimeDelta::FromDays(2))
     return true;
   return false;
 }
 
 bool SSLErrorClassification::IsUserClockInTheFuture(
     const base::Time& time_now) {
   base::Time build_time;
-  if (!g_testing_build_time.is_null()) {
-    build_time = g_testing_build_time;
+  if (!g_testing_build_time.Get().is_null()) {
+    build_time = g_testing_build_time.Get();
   } else {
 #if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
     return false;
 #else
     build_time = base::GetBuildTime();
 #endif
   }
 
   if (time_now > build_time + base::TimeDelta::FromDays(365))
     return true;
   return false;
 }
 
 // static
 void SSLErrorClassification::SetBuildTimeForTesting(
     const base::Time& testing_time) {
-  g_testing_build_time = testing_time;
+  g_testing_build_time.Get() = testing_time;
 }
 
 bool SSLErrorClassification::MaybeWindowsLacksSHA256Support() {
 #if defined(OS_WIN)
   return !base::win::MaybeHasSHA256Support();
 #else
   return false;
 #endif
 }
 
@@ skipping 254 matching lines @@
     // sure we don't clear the captive protal flag, since the interstitial was
     // potentially caused by the captive portal.
     captive_portal_detected_ = captive_portal_detected_ ||
         (results->result == captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL);
     // Also keep track of non-HTTP portals and error cases.
     captive_portal_no_response_ = captive_portal_no_response_ ||
         (results->result == captive_portal::RESULT_NO_RESPONSE);
   }
 #endif
 }